[FFmpeg-devel] [PATCH] mxfdec: make it work with other calling conventions
Wed Jun 30 22:58:29 CEST 2010
On Wed, Jun 30, 2010 at 10:02:50AM +0100, M?ns Rullg?rd wrote:
> Michael Niedermayer <michaelni at gmx.at> writes:
> > On Tue, Jun 29, 2010 at 11:36:50PM +0100, M?ns Rullg?rd wrote:
> >> Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
> > [...]
> >> >> >+#define METADATA_READ_FUNC(name) int name(void *arg, ByteIOContext *pb, int tag, int size, UID uid)
> >> >>
> >> >> I don't like the #define.
> >> >
> >> > Well, the alternative is having to change every single read function
> >> > manually in case you'd ever need an additional parameter.
> >> > And I found it very hard to find them.
> >> I'm with Reimar on this one.
> >> If you don't like it, fix it in some
> >> other way, but don't just say no.
> > so we can finally export libavutil/intreadwrite.h
> No, because it depends on compiler-specific settings in config.h.
> Without that information, it will be reduced to reading bytes at a
> time and shifting.
> > you know people do alraedy use it, it is de facto a public header
> It is not. What those people are doing is tying a noose around their
> own necks.
what you suggest is like sitting in a cave with a piece of
animal skin eating raw meat. And saying i wont use these matches, i might
burn my finger.
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel