[FFmpeg-devel] [PATCH] mxfdec: make it work with other calling conventions
Wed Jun 30 23:38:56 CEST 2010
On Wed, Jun 30, 2010 at 02:07:38PM -0700, Baptiste Coudurier wrote:
> Also a few functions do not use all the parameters, when using func
> pointers, it will cause warnings (unused arguments), with
> unspecified prototype, it won't.
??? Unused argument warnings don't depend on how you call a function,
at least I have never seen a compiler where this is the case.
> But that's more an explanation of
> why there isn't any prototype for the read() function.
I expected that is because pointers to functions with a different
number of arguments were stored there, but that is more of an argument
_for_ making it an error, since this allowed the fact that the
code would crash with stdcall and all other calle-restores-stack calling
conventions to go by unnoticed, without even a warning.
More information about the ffmpeg-devel