[FFmpeg-devel] Patch to fix qtrle endian issue with rgb555 pixel format

[Michael Niedermayer]

On Wed, Mar 03, 2010 at 02:17:50PM +0100, Alexis Ballier wrote:
> 2010/3/2 Michael Niedermayer <michaelni at gmx.at>:
> > On Mon, Mar 01, 2010 at 10:57:11PM -0800, Mo DeJong wrote:
> >> As far as I could tell, there is no support in libswscale for
> >> converting a rgb555le to rgb555be, and it is not clear how to add that
> >> support in a generic way. Correct me if I am wrong here, but it seems
> >> to me the -pix_fmt passed on the command line should be "-pix_fmt
> >> rgb555" and not "-pix_fmt rgb555be" which would be required if
> >> PIX_FMT_RGB555BE was put into the pix_fmts for this codec. My patch
> >> makes the minimal change needed to get the quicktime encoder working
> >> the way it seems it should be, please advise if there is a clearly
> >> better approach.
> >
> > fix swscale, if swscale is lacking support.
> 
> I did send a patch for exactly this purpose some time ago [1]... my
> understanding was that it was rejected because:
> - you didnt care about non native endian formats
> - the fastest version increased too much the code/object size
> - I didn't want to submit a patch that was obviously suboptimal in
> terms of speed

to me it felt like you just run away in the middle of review
anyway, what has apparently been missed in the old thread is that
the c converter can be implemented purly by changing the yuv2rgb tables
without touching the inner loops.
this should be optimal in your definition as well, so i expect a new
patch from you :)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 2
"100% positive feedback" - "All either got their money back or didnt complain"
"Best seller ever, very honest" - "Seller refunded buyer after failed scam"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100303/a9dfee6d/attachment.pgp>