[FFmpeg-devel] [PATCH] asf chapter support

Benoit Fouet benoit.fouet
Mon Mar 8 14:13:22 CET 2010


On Mon, 08 Mar 2010 14:01:39 +0100 Vladimir Pantelic wrote:
> Michael Niedermayer wrote:
> > On Mon, Mar 08, 2010 at 12:12:39PM +0100, Vladimir Pantelic wrote:
> >>  Michael Niedermayer wrote:
> >>>  On Fri, Feb 26, 2010 at 09:56:12AM +0100, Vladimir Pantelic wrote:
> >>>>   ASF supports "markers" which are a name and a time stamp,
> >>>>   attached patch uses them to crate lavf chapters.
> >>>>
> >>>>   As the markers only provide a start time, I use the start
> >>>>   time of the next marker or the total duration of the file
> >>>>   as the end time for the chapter.
> >>>
> >>>  see compute_chapters_end()
> >>
> >>  thx, that makes a much shorter patch.
> >>
> >>>  [...]
> >>>>   +//av_log(NULL, AV_LOG_ERROR, "add:  start %12lld  end %12lld name
> >>>>  %s\n", last_pres_time, pres_time, name);
> >>>
> >>>  ehm
> >>
> >>  removed, together with some unused variables that were write only.
> >>
> >>  v2 patch attached.
> >>
> >
> >>   asf.c    |    4 ++++
> >>   asf.h    |    1 +
> >>   asfdec.c |   27 +++++++++++++++++++++++++++
> >>   3 files changed, 32 insertions(+)
> >>  1834f66decb3a2ff318b6131ecea1eac31c3a65f  asf_chapters_v2.patch
> >
> > ok if tested
> 
> make test passes. It also works with an ASF file that I have here where
> I added chapters (markers) using some M$ asf mangling tool.
> 

applied then.

Ben



More information about the ffmpeg-devel mailing list