[FFmpeg-devel] [PATCH] Kega Game Video (KGV1) decoder

Michael Niedermayer michaelni
Tue Mar 9 00:45:05 CET 2010


On Wed, Mar 03, 2010 at 07:48:43PM -0600, Daniel Verkamp wrote:
> On Wed, Mar 3, 2010 at 5:47 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Wed, Mar 03, 2010 at 05:23:32PM -0600, Daniel Verkamp wrote:
> >> On Tue, Mar 2, 2010 at 4:37 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> >> > On Tue, Mar 02, 2010 at 11:46:38AM -0600, Daniel Verkamp wrote:
> >> >> On Wed, Feb 3, 2010 at 9:02 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> >> >> > On Wed, Feb 03, 2010 at 11:49:32AM -0600, Daniel Verkamp wrote:
> >> >> >> On Wed, Feb 3, 2010 at 10:41 AM, Daniel Verkamp <daniel at drv.nu> wrote:
> > [...]
> >> >> + ? ?c->pic.buffer_hints = FF_BUFFER_HINTS_VALID | FF_BUFFER_HINTS_PRESERVE
> >> >> + ? ? ? ? ? ? ? ? ? ? ? ?| FF_BUFFER_HINTS_REUSABLE;
> >> >
> >> > that should have no effect if you dont use *get_buffer()
> >> >
> >>
> >> Ok, removed.
> > [...]
> >> + ? ?c->pic.buffer_hints = FF_BUFFER_HINTS_VALID | FF_BUFFER_HINTS_PRESERVE
> >> + ? ? ? ? ? ? ? ? ? ? ? ?| FF_BUFFER_HINTS_REUSABLE;
> >
> > the more certain people are that they attached a patch
> > the less certain it is the correct one
> >
> 
> Indeed, git user error... once more, with feeling.

[...]

> +                if (outcnt - offset < 0)

if (outcnt < offset)

should be ok except that

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No great genius has ever existed without some touch of madness. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100309/c4a105f4/attachment.pgp>



More information about the ffmpeg-devel mailing list