[FFmpeg-devel] ff_idct_xvid_sse2-cannot-be-inline.patch

[Michael Niedermayer]

On Mon, Mar 08, 2010 at 06:43:11PM -0500, Pavel Pavlov wrote:
> > > The function ff_idct_xvid_sse2 simply cannot be static because it's
> > referenced inside dsputil_mmx.c:
> > >   c->idct    = ff_idct_xvid_sse2;
> > > I have no idea how gcc could compile/link this kind of code. There
> > should have been a link error at least
> > > <ff_idct_xvid_sse2-cannot-be-inline.patch>
> > 
> > It's C99 inline. C99 doesn't make inline functions static if there's a
> > prototype, and there is one.
> > 
> 
> 
> I don't know why I wrote static, if it's actually inline :)
> Anyways, I'm getting a link error and I have to remove inline to fix it.

the function in question must be marked inline due to speed reasons

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Frequently ignored awnser#1 FFmpeg bugs should be sent to our bugtracker. User
questions about the command line tools should be sent to the ffmpeg-user ML.
And questions about how to use libav* should be sent to the libav-user ML.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100309/732dafa5/attachment.pgp>