[FFmpeg-devel] [PATCH] Use the actual RTSP peer IP for RTP sessions

Martin Storsjö martin
Tue Mar 9 17:05:13 CET 2010


On Tue, 9 Mar 2010, Martin Storsj? wrote:

> On Mon, 8 Mar 2010, Ronald S. Bultje wrote:
> 
> > On Mon, Mar 8, 2010 at 2:09 PM, Martin Storsj? <martin at martin.st> wrote:
> > > On Mon, 8 Mar 2010, Ronald S. Bultje wrote:
> > >> RTSP already does only use control_uri, where relevant at least. We
> > >> should never modify AVFormatContext->anything unless it is documented
> > >> as a demuxer-set value.
> > >
> > > It still uses s->filename in a few places, but the attached patch takes
> > > care of that.
> > 
> > Hm.. So the original introduction of that thing fixed a bug playing
> > back streams that require a session key. I think I logged it on issue
> > tracker. Could you look up that bug and make sure the patch doesn't
> > break it? (I don't know if it does, just want to prevent regressions.)
> 
> Tested with the URL you gave me, and it worked just as well as before the 
> patch. The only change in the communication is that the TEARDOWN uses 
> rt->control_uri instead of the original URL - this still gives a RTSP/1.0 
> 200 OK, just as before.

Ok'd on irc, applied.

// Martin



More information about the ffmpeg-devel mailing list