[FFmpeg-devel] libavcodec/pthread.c:138: error: no previous prototype for 'avcodec_thread_execute2'

[Michael Niedermayer]

On Mon, Mar 15, 2010 at 09:56:59AM +0100, Benoit Fouet wrote:
> On Sun, 14 Mar 2010 13:46:19 +0000 M?ns Rullg?rd wrote:
> > Michael Niedermayer <michaelni at gmx.at> writes:
> > 
> > > On Sun, Mar 14, 2010 at 02:00:12AM +0000, M?ns Rullg?rd wrote:
> > >> Michael Niedermayer <michaelni at gmx.at> writes:
> > >> 
> > >> > On Mon, Mar 08, 2010 at 04:57:24PM +0100, Benoit Fouet wrote:
> > >> > [...]
> > >> >> @@ -3255,9 +3255,11 @@ enum PixelFormat avcodec_default_get_for                                                                             
> > >> >> 
> > >> >>  int avcodec_thread_init(AVCodecContext *s, int thread_count);
> > >> >>  void avcodec_thread_free(AVCodecContext *s);
> > >> >> +#if LIBAVCODEC_VERSION_MAJOR < 53
> > >> >>  int avcodec_thread_execute(AVCodecContext *s, int (*func)(AVCodecContext *c2, void *arg2),void *arg, int *ret, int count, int size);
> > >> >
> > >> >>  int avcodec_default_execute(AVCodecContext *c, int (*func)(AVCodecContext *c2, void *arg2),void *arg, int *ret, int count, int size);
> > >> >>  int avcodec_default_execute2(AVCodecContext *c, int (*func)(AVCodecContext *c2, void *arg2, int, int),void *arg, int *ret, int count);
> > >> >
> > >> > these 2 are usefull to set AVCodecContext->execute* to a non threaded
> > >> > variant which a user app might wish to do
> > >> 
> > >> Those are the defaults if avcodec_thread_init() isn't called.  There
> > >> is no need to export them.
> > >
> > > I thought some implementations might want to use it as fallback or to
> > > pass execution on after doing some processing.
> > 
> > In that case they should be properly documented.
> > 
> > > We allso have such a thing for get_buffer/release_buffer() and its used
> > 
> > Those too.
> > 
> 
> OK, so here is an updated patch to remove avcodec_thread_execute:

looks ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100315/0037dc1c/attachment.pgp>