[FFmpeg-devel] [PATCH] Add loop option to ffplay

[Robert Krüger]

On 20.03.2010, at 12:08, Stefano Sabatini wrote:

> On date Saturday 2010-03-20 08:53:16 +0100, Robert Kr?ger encoded:
>> 
>> On 19.03.2010, at 21:07, Michael Niedermayer wrote:
>> 
>>> On Thu, Mar 18, 2010 at 04:56:53PM +0100, Robert Kr?ger wrote:
>>>> 
>>>> OK, now to the correct list, sorry.
>>>> 
>>>> The following patch adds a -loop option to ffplay, which I find
>>>> very handy when reviewing raw footage.
>>>> 
>>>> Provided this is generally accepted, there is the question how to
>>>> treat the conflict between autoexit and loop. One could change
>>>> this from OPT_BOOL to a function which in both cases aborts with
>>>> an error because these two things contradict or could output a
>>>> warning telling the user that only one will be used or it could
>>>> just do one of the two things (which is what is implemented in
>>>> this patch but probably not the most user-friendly).
>>>> 
>>>> Let me know which one it shall be and I will modify the patch
>>>> accordingly.
>>> 
>>> make loop take an argument that specifies how oftten too loop and
>>> afterwards exist if autoexit is there 
>>> 
>> 
>> and not allow the user to specify to loop indefinitely other than
>> with a high number?
> 
> loop will take a number as argument, when count == loop -> exit if
> autoexit, a negative value may mean "loop forever", in the latter case
> autoexit would be just ignored.
> 

OK, objections anyone? The I'll modify the patch accordingly. I'm happy with that and I don't mean to be nitpicking but as far as "ffplay -loop -1 -autoexit" is concerned the situation would then be the same as in my original patch with "ffplay -loop -autoexit", just with the additional (useful) option to specify a loop count.

Regards,

Robert