[FFmpeg-devel] [PATCH] Add support for digest auth in the http and rtsp protocols

[Ronald S. Bultje]

Hi,

On Thu, Mar 25, 2010 at 4:09 AM, Martin Storsj? <martin at martin.st> wrote:
> Split the RTSP updates into smaller parts as requested by Ronald, by first
> changing to use the generic http auth code but hardcoded to basic auth,
> then later is changed to actually parse the auth headers and choose an
> auth method depending on what the server suggests.
[..]
> +static int find_method_and_url(char *buf, const char **method, const char **url)
[..]

As said on IRC, this is a little ugly, we're basically creating a line
from elements and then splitting again.

You can say no then I'll do it ;-), but we need to split this function
a little so it takes (instead of just "cmd") a "method", "uri" and
"cmd" (which is original cmd - method/uri), and then have
ff_rtsp_send_cmd_with_content_async() construct the correct first
line. Might not be ideal, but will prevent the having to split it
again, which I personally consider ugly.

Luca (B), is that approach OK with you?

Ronald