[FFmpeg-devel] Fwd: [PATCH] Psygnosis YOP demuxer

[Michael Niedermayer]

On Sat, Mar 27, 2010 at 07:08:11AM +0530, Mohamed Naufal wrote:
> On 27 March 2010 06:35, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Sat, Mar 27, 2010 at 01:18:51AM +0530, Mohamed Naufal wrote:
> >> On 26 March 2010 21:06, Michael Niedermayer <michaelni at gmx.at> wrote:
> >>
> >>
> >> [...]
> >>
> >> >> + * Take s->dstptr to the next macroblock in sequence.
> >> >> + */
> >> >> +static void yop_next_macroblock(YopDecContext *s)
> >> >> +{
> >> >> + ? ?// If we are advancing to the next row of macroblocks
> >> >> + ? ?if (s->row_pos == s->frame.linesize[0] - 2) {
> >> >> + ? ? ? ?s->dstptr ?+= s->frame.linesize[0];
> >> >
> >> > this looks like it assumes width == linesize
> >> > this is not guranteed by get_buffer()
> >> >
> >>
> >>
> >> But width is assigned to linesize after get_buffer().
> >
> > not pretty but i see this probably isnt easy to avoid
> >
> > did you test the code with damaged files (tools/trasher)
> > it shouldnt crash or hang with it
> >
> > except that its probably ok
> >
> 
> Finally! ;)
> Checked. Works without problems.
> Also would it be appropriate to add my name to copyright?

i think so, yes

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There will always be a question for which you do not know the correct awnser.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100327/7a12f9e8/attachment.pgp>