[FFmpeg-devel] Fwd: [PATCH] Psygnosis YOP demuxer

Reimar Döffinger Reimar.Doeffinger
Sat Mar 27 14:23:59 CET 2010


On Sat, Mar 27, 2010 at 01:15:46PM +0100, Michael Niedermayer wrote:
> On Sat, Mar 27, 2010 at 01:00:38PM +0100, Reimar D?ffinger wrote:
> > you use get_buffer, but changing linesize is incompatible with DR.
> > You either need to respect the linesize as it is or do the buffer
> > management without get_buffer.
> 
> if CODEC_CAP_DR1 is not set get_buffer == our internal get_buffer

That's what I though first was the definition of CODEC_CAP_DR1, but
when I looked it up the documentation said something else.
But I now found that the get_buffer documentation mandates this behaviour
so I guess it is ok from that aspect.
I'm not 100% sure there will not be any issues since the line alignment
might be less than what we usually promise, but if there's no easy
way to fix it I withdraw my objection.

> > Or, if we really want this to be a valid way of doing it, improve
> > that CODEC_CAP_DR1 documentation and add a comment that this codec
> > intentionally does not set CODEC_CAP_DR1 because it can not work
> > with it.
> 
> our documentation is shit but you coul interpret it as
> CODEC_CAP_DR1 -> codec uses get_buffer
> but not neccassarily <-

Why not add a "makes pigs fly. Or maybe not.", that's about as useful :-)
Hopefully what I committed makes it clearer.



More information about the ffmpeg-devel mailing list