[FFmpeg-devel] [PATCH] share xiph rtp code

Martin Storsjö martin
Sun Mar 28 14:27:57 CEST 2010


On Sun, 28 Mar 2010, Josh Allmann wrote:

> Everything can be shared between theora and vorbis, so I moved code
> into rtpdec_xiph.c/h, and removed the old rtpdec_theora and
> rtpdec_vorbis files.
> With this, the vorbis depayloader inherits all the features that were
> added to theora's, including dropped-packet handling, split frames,
> and multiple frames per packet.
> 
> This patch series is dependent, one after the other.
> 
> 001: moves the original rtpdec_theora code to rtpdec_xiph, and updates
> the makefile and related accordingly.
> 
> 002: renaming and other cosmetic changes to rtpdec_xiph

You do some cosmetic changes here (e.g. indenting) - such things are 
preferred to be done in several steps, i.e., first just the actual 
changes, then reindent as a purely cosmetic commit. Good for you that git 
can do that (almost) for you - if you make the patches with -w, it will 
skip lines with only whitespace modifications.

> 003: moves vorbis depayloader to rtpdec_xiph
> 
> Tested this with feng and gst-rtsp, and things seem to work but if
> someone could double-check the audio for me that'd be great.

Looks good to me in general - if the difference between theora and vorbis 
really is that small, it really is good to have the code shared. :-)

// Martin



More information about the ffmpeg-devel mailing list