[FFmpeg-devel] [PATCH] avcodec_copy_context()

[Michael Niedermayer]

On Wed, Mar 31, 2010 at 03:53:23PM -0400, Ronald S. Bultje wrote:
> Hi,
> 
> On Wed, Mar 31, 2010 at 3:47 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Wed, Mar 31, 2010 at 11:19:18AM -0400, Ronald S. Bultje wrote:
> >> On Wed, Mar 31, 2010 at 10:53 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> >> > On Wed, Mar 31, 2010 at 10:11:11AM -0400, Ronald S. Bultje wrote:
> >> >> On Wed, Mar 31, 2010 at 9:59 AM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
> >> >> > On Wed, Mar 31, 2010 at 6:00 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> >> >> >> On Tue, Mar 30, 2010 at 02:23:03PM -0400, Ronald S. Bultje wrote:
> >> >> >>> + * @param dest target codec context, should be allocated with
> >> >> >>> + * ? ? ? ? ? ? #avcodec_alloc_context(), but otherwise uninitialized
> >> >> >>
> >> >> >> this should be checked if(->codec) or so maybe
> >> >> >
> >> >> > Coding error, so should be assert(), will add.
> >> >
> >> > avcodec* is public api and public api should not call abort() for invalid
> >> > user arguments imho
> >>
> >> You're right, now that I think about it. AVERROR(EFAULT) OK then?
> >
> > EINVAL id say
> 
> New patch attached.
> 
> Ronald

>  avcodec.h |   13 +++++++++++++
>  options.c |   60 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 73 insertions(+)
> 2d67df78ac9cdda932ab19b7c0c13979dc9e8f97  avcodec_copy_context.patch

looks ok

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Awnsering whenever a program halts or runs forever is
On a turing machine, in general impossible (turings halting problem).
On any real computer, always possible as a real computer has a finite number
of states N, and will either halt in less than N cycles or never halt.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100331/59c80c80/attachment.pgp>