[FFmpeg-devel] [PATCH] Fix non-rounding up to next 16-bit aligned bug in IFF decoder

Sebastian Vater cdgs.basty
Mon May 3 16:05:59 CEST 2010


M?ns Rullg?rd a ?crit :
> Sebastian Vater <cdgs.basty at googlemail.com> writes:
>
>   
>> M?ns Rullg?rd a ?crit :
>>     
>>> Sebastian Vater <cdgs.basty at googlemail.com> writes:
>>>
>>> Would you like an account on a PPC machine?
>>>   
>>>       
>> Yes, that would really be nice...so I can test it straight away on be.
>>
>> Thank you very much in advance!
>>     
>
> Send me your ssh public key and desired username.
>
>   
>>>> Little endian was tested by me, so it works now for both...if someone
>>>> could help me shortening the #define stuff here for the 8-bit table,
>>>> I'ld be glad.
>>>>     
>>>>         
>>> I will, when you send a patch that applies to current svn.
>>>   
>>>       
>> Thanks again, so here you have your desired patch.
>>
>> But why you didn't just apply the iff-decoder-fix.patch and then the
>> iff-decoder-fix-heavy-dp8.patch?
>>     
>
> I didn't know what I had to apply or in what order.
>
>   
>> Or should I integrate that decoder fix (word alignment) into this patch?
>>     
>
> No.
>
> Anyway, here's a cleaner table generation.  This gives the same output
> as your patch, which is different from the unpatched svn.  I've lost
> track of all the different bugs...
>   

Thank you! I have tested and added it to my code. Works like a charm!

So here is the final patch! It should be applied after
iff-decoder-fix.patch (I reposted it just today).

So please apply iff-decoder-fix (which fixes width to word alignment)
first and then this patch.

Please note that this patch depends on iff-decoder-fix.patch anyway,
since it requires the word alignment.
Since no one has been complaining about this patch except the FFALIGN
stuff which I just fixed.

-- 

Best regards,
                   :-) Basty/CDGS (-:

-------------- next part --------------
A non-text attachment was scrubbed...
Name: iff-decoder-fix-heavy-dp8.patch
Type: text/x-diff
Size: 3198 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100503/760d9618/attachment.patch>



More information about the ffmpeg-devel mailing list