[FFmpeg-devel] [PATCH] Chromium MKV patches
Wed May 5 21:51:47 CEST 2010
On May 5, 2010, at 7:17 AM, Michael Niedermayer wrote:
> On Wed, May 05, 2010 at 05:18:20AM -0400, David Conrad wrote:
>> Here are the useful patches from chromium for the mkv demuxer. 1 doesn't fix any actual issues that I'm aware of, but might make it easier to spot any if they exist.
>> Another change made was ensuring sample_rate was nonzero, but AFAIK a zero sample_rate meant unknown and applications should handle that instead of the demuxer inventing a rate?
> i was unaware that matroska allowed a undefined sample_rate, thats broken
> design for a container that normally stores the sample_rate
> the solution may be to set needs_parsing to headers only if its not a
> higher value alraedy
> having the problematic mkv file woulf of course help to see what exactly
> is the problem
It's not that it allows undefined sample_rate, but rather that it's possible for a file to have 0 written for sample_rate, which is probably true of most containers.
need_parsing is already set to AVSTREAM_PARSE_HEADERS for everything except aac.
I'll ask for the file, but google's lawyers are apparently deathly afraid of sharing even public-domain videos.
More information about the ffmpeg-devel