[FFmpeg-devel] [PATCH] Make cmdutils.c:print_error() use strerror() if av_strerror() fails (e.g. if strerror_r() is not defined)

[Michael Niedermayer]

On Wed, May 05, 2010 at 11:49:02PM +0200, Stefano Sabatini wrote:
> On date Wednesday 2010-05-05 02:20:36 +0200, Michael Niedermayer encoded:
> > On Wed, May 05, 2010 at 12:37:52AM +0200, Stefano Sabatini wrote:
> > > On date Tuesday 2010-05-04 17:12:24 +0200, Michael Niedermayer encoded:
[...]
> > [...]
> > >  cmdutils.h |    8 ++++++++
> > >  1 file changed, 8 insertions(+)
> > > 386c4acd4be5a4e8b73567c40fb89a3164d67089  0003-Document-cmdutils.c-print_error.patch
> > > >From f41624ff126f9ee41a2ac9dbaef6c49d0a103a1d Mon Sep 17 00:00:00 2001
> > > From: Stefano Sabatini <stefano.sabatini-lala at poste.it>
> > > Date: Wed, 5 May 2010 00:11:57 +0200
> > > Subject: [PATCH 3/6] Document cmdutils.c:print_error().
> > > 
> > > ---
> > >  cmdutils.h |    8 ++++++++
> > >  1 files changed, 8 insertions(+), 0 deletions(-)
> > > 
> > > diff --git a/cmdutils.h b/cmdutils.h
> > > index ad8cefd..86da06c 100644
> > > --- a/cmdutils.h
> > > +++ b/cmdutils.h
> > > @@ -134,6 +134,14 @@ void parse_options(int argc, char **argv, const OptionDef *options,
> > >  
> > >  void set_context_opts(void *ctx, void *opts_ctx, int flags);
> > >  
> > > +/**
> > > + * Prints a string indicating filename and a description of the error
> > > + * code err to stderr.
> > 
> > this sounds a bit uneasy and rough
> > 
> > what about
> > Prints a human readable error message
> > 
> > 
> > 
> > > + * The use of this function may be unsafe in a multithreaded
> > > + * application.
> > 
> > ... if have_strerwhatere_r is not available
> 
> Patch updated.
> -- 
> FFmpeg = Foolish and Frenzy MultiPurpose Extensive Gorilla

>  cmdutils.h |    9 +++++++++
>  1 file changed, 9 insertions(+)
> 388fbd4c57be53e44aa1e0becb9cb475e737d30d  0001-Document-cmdutils.c-print_error.patch
> >From 062ffa1bd979bc05bb35067b70db0fb69ad78055 Mon Sep 17 00:00:00 2001
> From: Stefano Sabatini <stefano.sabatini-lala at poste.it>
> Date: Wed, 5 May 2010 00:11:57 +0200
> Subject: [PATCH 1/2] Document cmdutils.c:print_error().

mostly ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100506/ac1b054c/attachment.pgp>