[FFmpeg-devel] [PATCH] IFF: Make lavf/iff.c stop using ff_cmap_read_palette

Sebastian Vater cdgs.basty
Sun May 9 20:38:12 CEST 2010

Martin Storsj? a ?crit :
> On Sun, 9 May 2010, Sebastian Vater wrote:
>> Martin recommeded to do these as a separate patch.
>> It removes call to ff_cmap_read_palette in lavf/iff.c for preparation of
>> the HAM patch.
> Does an old lavc/iff.c handle a new demuxer behaving in this way, or why 
> is the change to lavc/iff.c included here? In that case, this can lead to 
> problems when mixing lavf/lavc versions.

Removing ff_cmap_read_palette from lavf/iff.c requires that the decoder
handles IFF-PBM uncompressed files by itself, since it can't be passed

But that isn't a problem, because old lavf/iff.c doesn't pass the data
at all to lavc/iff.c in that case.

However a new lavf/iff.c could pass to old lavc/iff.c in that case it
won't decode uncompressed IFF-PBM files anymore. It would threat them as
IFF-ILBM uncompressed and therefore call the decodeplane8 version which
will result in corrupted image data.

The only way I see to fix this is to increment the lavc version number
or to add the new IFF_EXTRA_CONTEXT_SIZE stuff, also. What do you suggest?


Best regards,
                   :-) Basty/CDGS (-:

More information about the ffmpeg-devel mailing list