[FFmpeg-devel] [PATCH] IFF: Make lavf/iff.c stop using ff_cmap_read_palette

Sebastian Vater cdgs.basty
Sun May 9 21:41:02 CEST 2010

Martin Storsj? a ?crit :
> Ok, so this is a general problem that you would have got even if you 
> didn't split this out as a separate patch, but now it is much much easier 
> to spot and discuss, instead of having it mixed up in the middle of 
> discussions of fifty other things. See how splitting things into coherent 
> pieces aid the review?

Yes, can't deny that! ;)

> A third option would be to make a local copy of ff_cmap_read_palette in 
> lavf, so that lavf/iff wouldn't depend on functions from lavc/iff, but 
> that's a bit of code duplication, and probably not appreciated.

Yes this would be really ugly, although possible.

> In this case, if a new version of lavf demuxes stuff to a new "format" 
> which earlier lavc doesn't support, I find it acceptable, especially since 
> it's a fringe format... If the old lavc still decodes it, but incorrectly, 
> that's a problem with the earlier lavc version which is fixed by a newer 
> version of lavc.

So I hope, it's fine how I solved that right now...


Best regards,
                   :-) Basty/CDGS (-

More information about the ffmpeg-devel mailing list