[FFmpeg-devel] [PATCH] Implement brg4 and rgb4 input support in libswscale
Fri May 14 01:33:38 CEST 2010
On date Friday 2010-05-14 00:50:29 +0200, Michael Niedermayer encoded:
> On Fri, May 14, 2010 at 12:46:10AM +0200, Stefano Sabatini wrote:
> > Hi,
> > here it is my naive implementation of subject, first attachment shows
> > the code used to generate the used tables.
> the table coefficients should be adjusted depenending on the
> yuv type (sws_setColorspaceDetails)
> (and yes i know we are missing this in other rgb->yuv code so its not
> mandatory for patch approval but would be very nice if we would be
> slowly fixing these shortcommings)
Do you prefer to use hardcoded tables or dynamically generated ones?
The latter would slow down the library init phase, but would be more
robust if there is the possibility that for whatever reason we change
the YUV <-> RGB conversion tables coefficients, also should be more
intelligible to the casual reader.
FFmpeg = Funny and Fancy Mega Philosophical Everlasting Guru
More information about the ffmpeg-devel