[FFmpeg-devel] [PATCH] IFF: Add the HAM stuff
Sun May 16 01:03:34 CEST 2010
On date Sunday 2010-05-16 00:40:21 +0200, Sebastian Vater encoded:
> Stefano Sabatini a ?crit :
> >> +/**
> >> + * Extracts the IFF extra context and updates internal
> >> + * decoder structures.
> >> + *
> >> + * @param avctx the AVCodecContext where to extract extra context to
> >> + * @param avpkt the AVPacket to extract extra context from
> >> + *
> > Nit+++: no need for this empty newline
> Which empty new line? They're just cosmetics like in the other
> functions, too. So you see return value separated to args.
Well it's a level 3 nit, so it's really not important if you prefer
that way (just in the most doxies in FFmpeg there is no empty newline
Patch looks fine to me, I suppose it has been tested and works, if no
one has more comments I'll apply it in few days.
Keep up the excellent work!
FFmpeg = Fancy & Faithless MultiPurpose Exxagerate Guru
More information about the ffmpeg-devel