[FFmpeg-devel] [PATCH] IFF: Merge lots of duplicate code into a single function

Sebastian Vater cdgs.basty
Sun May 16 18:29:10 CEST 2010


Ronald S. Bultje a ?crit :
> Hi,
>
> On Sun, May 16, 2010 at 12:06 PM, Sebastian Vater
> <cdgs.basty at googlemail.com> wrote:
>   
>> Besides this, I added Stefano's hint about get_buffer returning err
>> instead -1 here, since I had to introduce err variable here anyway.
>>     
> [..]
>   
>> -    if (avctx->reget_buffer(avctx, &s->frame) < 0){
>> +    if ((err = avctx->reget_buffer(avctx, &s->frame)) < 0) {
>>          av_log(avctx, AV_LOG_ERROR, "get_buffer() failed\n");
>> -        return -1;
>> +        return err;
>>      }
>>     
>
> Well, that should be a separate patch, but is OK otherwise... Rest of
> patch is OK also..
>   

Fixed!

-- 

Best regards,
                   :-) Basty/CDGS (-:

-------------- next part --------------
A non-text attachment was scrubbed...
Name: iff-function-merge.patch
Type: text/x-patch
Size: 5970 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100516/aa3efb2a/attachment.bin>



More information about the ffmpeg-devel mailing list