[FFmpeg-devel] [PATCH] fix unconditional H264 references to SVQ3
Sat May 22 22:13:47 CEST 2010
On May 22, 2010, at 8:54 AM, M?ns Rullg?rd wrote:
> Howard Chu <hyc at highlandsun.com> writes:
>> Carl Eugen Hoyos wrote:
>>> Howard Chu<hyc<at> highlandsun.com> writes:
>>>> The error occurred at link time, when compiling with optimization turned off.
>>> AFAICT, this is unsupported (and much worse, it does not match your original
>>> patch description).
>> What are you talking about? There is a configure switch to turn off
>> svq3, and I used that configure switch but there are still references
>> to svq3 functions that ignore the configure switch. How is that not
>> what my original description says? How is that unsupported? What's the
>> point of the configure switch then? What's the point of the
>> CONFIG_SVQ3_DECODER macro then??
> Turning off all optimisation is not supported. Specifically, dead
> code elimination must always be performed.
gcc removes if (0) at -O0. Maybe 'int is_h264 = 1; if (!is_h264)' is too much for it?
I wouldn't mind moving CONFIG_SVQ3_DECODER into the if.
More information about the ffmpeg-devel