[FFmpeg-devel] [PATCH] add md5 muxer
Sun May 23 20:29:06 CEST 2010
On Sun, May 23, 2010 at 07:38:10PM +0200, Michael Niedermayer wrote:
> On Sun, May 23, 2010 at 04:02:38PM +0100, M?ns Rullg?rd wrote:
> > Mike Melanson <mike at multimedia.cx> writes:
> > > Reimar D?ffinger wrote:
> > >> On Sun, May 23, 2010 at 01:38:21PM +0100, M?ns Rullg?rd wrote:
> > >>> Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
> > >>>
> > >>>> Hello,
> > >>>> we have -f crc, but IMO 32 bit crc are a bit little for a whole file and
> > >>>> also we use md5sum in the regression tests, so I'd propose to add a -f
> > >>>> md5 as in attached patch.
> > >>> And as usual, people adding so much to the list of requirements that
> > >>> nothing at all got done in the end.
> > >>>
> > >>> Just apply this so we can use it.
> > >> Applied.
> > >> Attached would extend this by a framemd5 muxer in addition.
> > >
> > > Whatever happened to the bikeshed arguments regarding whether we
> > > should also support some variant of SHA?
> > We decided to ignore them. If people want that, they can send their
> > own patches.
> i agree with this patch being applied
> i dont agree to ignoring review comments though, one should at least
> attempt to politely ask the person commenting first. Chances are
> one would quickly find a solution if the comment really went too far
> which it did in this case.
It wasn't my intention to disrespect anyone by applied, just after re-reading
it I just concluded that nobody really objected to the patch in itself and improvements
could still be made afterwards + nobody cared enough to make any further comments
in a long time.
More information about the ffmpeg-devel