[FFmpeg-devel] [PATCH] lavfi test for 1-1 filters pixel format output

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

> On Mon, May 24, 2010 at 09:46:32PM +0100, M?ns Rullg?rd wrote:
>> Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:
>> 
>> > On date Monday 2010-05-24 02:43:44 +0200, Michael Niedermayer encoded:
>> >> On Sun, May 23, 2010 at 10:53:40PM +0200, Stefano Sabatini wrote:
>> >> > On date Thursday 2010-04-01 01:36:08 +0200, Michael Niedermayer encoded:
>> >> > > On Mon, Mar 22, 2010 at 11:52:12PM +0100, Stefano Sabatini wrote:
>> >> > > > Hi,
>> >> > > > 
>> >> > > > this test checks for the output of some selected filters with all the
>> >> > > > input pixel formats supported by each of the filters.
>> >> > > > 
>> >> > > > Only filters with exactly one input and one output are tested.
>> >> > > > 
>> >> > > > Note that many of the issued files *cannot be reproduced* y ffplay, as
>> >> > > > for many of them there is no support by nut.
>> >> > > > 
>> >> > > > While we'll find some way to extend nut for that, here it is the patch
>> >> > > > for the first review.
>> >> > [...]
>> >> > > anyway most of this patch falls under the shell script posix area
>> >> > > so review left to mans
>> 
>> Did I review this?  Of course not, or I would have told you it breaks
>> cross-builds (only if the test is run of course).
>
> everything that people add break your cross-builds
> also the original patch was posted more than 2 months ago and i explicitly
> asked you to review, and its code not run unless explicitly run

You could have pinged me about it.

> also as we are already discussing this, i will enable the stream copy tests
> if you dont. And of course ill try my best to no break your cross build but
> its undocumented stuff so i have no idea at all how to make sure i dont
> break them, how i could test them or how they work.

Sorry about that.  I know I said I'd look into it, but something got
in between and it slipped my mind.

-- 
M?ns Rullg?rd
mans at mansr.com