[FFmpeg-devel] [PATCH] H264 parser fix

Michael Niedermayer michaelni
Tue May 25 23:57:08 CEST 2010

On Tue, May 25, 2010 at 12:01:43PM -0700, Howard Chu wrote:
> Howard Chu wrote:
>> Carl Eugen Hoyos wrote:
>>> Michael Niedermayer<michaelni<at>   gmx.at>   writes:
>>>> if this is the issue the parser should be improved to suport the slghtly
>>>> differnt way to pack things and also to look in extradata.
>>> Which would (probably) fix FFmpeg issues 1831 and 1253.
>> I tried the mkv in 1831, it still has the same problem. Haven't looked at 
>> why yet.
> With this patch the video plays for a while, but SEGVs later on. Perhaps 
> the mkv file is truncated.

it looks like the sps is truncated but i did not investigate this deeply
there could be other issues like some bug in sps reading or in the mkv
anyway ive commited a check for that so it should get over that return -1
also note we apparently where failing on uninitialized memory so there is a
small chance a random player might have gotten over that by pure luck

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100525/f1b86930/attachment.pgp>

More information about the ffmpeg-devel mailing list