[FFmpeg-devel] [PATCH] PGS subtitle position
Sat Nov 6 17:12:20 CET 2010
On Sat, Nov 6, 2010 at 6:52 AM, Reimar D?ffinger
<Reimar.Doeffinger at gmx.de> wrote:
> On Sat, Nov 06, 2010 at 01:22:49PM +0100, Reimar D?ffinger wrote:
>> On Thu, Nov 04, 2010 at 11:30:58AM -0700, Mark Goodman wrote:
>> > - ? ? ? ?/* TODO: Blank context as subtitle should not be displayed.
>> > - ? ? ? ? * ? ? ? If the subtitle is blanked now the subtitle is not
>> > - ? ? ? ? * ? ? ? on screen long enough to read, due to a delay in
>> > - ? ? ? ? * ? ? ? initial display timing.
>> > - ? ? ? ? */
>> I still need to test it, however removing this
>> comment is not a good idea.
>> However, since it's not correct anyway I'll think of a way to
>> preserve it myself.
>> Ignoring the first byte however is unlikely to be correct,
>> there is a patch that attempts to handle it, however it it
>> ends up blanking the subtitle on the first palette change in
>> case of a fade-out (AFAICT anyway) instead of really at the end.
> Hm, that may have been a case of wrong testing.
> Anyway, can you try out attached patch?
Yes, I had planned on providing a subsequent patch that did exactly
this but was trying to make the minimal patch that made an
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
More information about the ffmpeg-devel