[FFmpeg-devel] [PATCH 3/3] Make opt_default(), return an error code rather than exit from the program.

Stefano Sabatini stefano.sabatini-lala
Sun Nov 7 00:53:35 CET 2010


On date Sunday 2010-11-07 00:38:48 +0100, Michael Niedermayer encoded:
> On Sat, Nov 06, 2010 at 03:02:57PM +0100, Stefano Sabatini wrote:
> > This allows the program to nicely handle the error, for example
> > providing detailed error explanation to the user or cleaning up the
> > allocated resources of the program.
> 
> there is plenty of code that does not check its return value
> and i dont think adding checks everywhere is a good idea

In general returning meaningful values *is* a good idea, but I'm
not going to add them to all the FFmpeg codebase, but *this patch* is
required by the previous patches in this series, to make ffmpeg prints
something useful after opt_default() is called, rather than just
abort.
-- 
FFmpeg = Fundamental and Foolish Martial Patchable Easy Geisha



More information about the ffmpeg-devel mailing list