[FFmpeg-devel] [PATCH 1/8] Deprecate avcodec_get_pix_fmt_name() in favor of the new av_get_pix_fmt_name().

[Stefano Sabatini]

On date Sunday 2010-11-07 00:57:08 +0100, Michael Niedermayer encoded:
> On Sat, Nov 06, 2010 at 02:12:43PM +0100, Stefano Sabatini wrote:
> > On date Saturday 2010-11-06 03:07:13 +0100, Michael Niedermayer encoded:
> > > On Fri, Nov 05, 2010 at 12:00:32PM +0100, Stefano Sabatini wrote:
> > > > Consistent with av_get_sample_fmt_name().
> > [...]
> > > > --- a/libavutil/pixdesc.c
> > > > +++ b/libavutil/pixdesc.c
> > > > @@ -814,6 +814,14 @@ static enum PixelFormat get_pix_fmt_internal(const char *name)
> > > >      return PIX_FMT_NONE;
> > > >  }
> > > >  
> > > > +const char *av_get_pix_fmt_name(enum PixelFormat pix_fmt)
> > > > +{
> > > > +    if (pix_fmt < 0 || pix_fmt >= PIX_FMT_NB)
> > > > +        return NULL;
> > > > +    else
> > > > +        return av_pix_fmt_descriptors[pix_fmt].name;
> > > > +}
> > > > +
> > > 
> > > iam against adding a function per field of a public structure.
> > 
> > Consistent with av_get_sample_fmt_name() so the user will expect to
> 
> The sample formats are desribed in a private struct, the pixel formats

I know all this, and I repeat what I already said,
av_pix_fmt_descriptors[pix_fmt].name is an awkward way for getting the
name of a pixel format and less safe (no check on pix_fmt range),
since this is a rather common functionality it makes sense IMO to have
a "shortcut" for it, even if it's possible to directly access the
pixdescs array.
-- 
FFmpeg = Fancy and Faithful Mastering Practical Enhancing Gospel