[FFmpeg-devel] [PATCH] ALS/BGMC: Clean initialization of lut status

Michael Niedermayer michaelni
Mon Nov 8 15:42:01 CET 2010


On Mon, Nov 08, 2010 at 10:44:16AM +0100, Thilo Borgmann wrote:
> 
> 
> > a while ago Ramiro reported a valgrind complaint to me that from time to
> > time crashes fate: "Conditional jump or move depends on uninitialised
> > value(s)").
> > 
> > Indeed lut_status[] was uninitialized in bgmc.c.
> > 
> > Patch attached. Thanks Justin for pointing me at the bug!
> 
> No one seems to object :)
> 
> > 
> > Regards,
> > Thilo
> > 
> > p.s. the patch changes ff_ functions in bgmc.c/h. Anything special to
> > have in mind in case of applying?
> 
>   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 
> p.s. but ping for this

are any of the changed functions used in another of our libs ?
if no its fine
if yes its likely still fine as it seems they just change signedness

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When the tyrant has disposed of foreign enemies by conquest or treaty, and
there is nothing more to fear from them, then he is always stirring up
some war or other, in order that the people may require a leader. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101108/09eb75d7/attachment.pgp>



More information about the ffmpeg-devel mailing list