[FFmpeg-devel] [PATCH] common ID3v2 support for all formats
Tue Nov 9 08:41:57 CET 2010
On Mon, Nov 08, 2010 at 04:00:43PM +0100, Anton Khirnov wrote:
> On Thu, Nov 04, 2010 at 08:04:32AM +0100, Reimar D?ffinger wrote:
> > On Thu, Nov 04, 2010 at 07:53:19AM +0100, Anton Khirnov wrote:
> > > On Wed, Nov 03, 2010 at 11:12:07PM +0100, Reimar D?ffinger wrote:
> > > > On second thought though I have to say that I can't think of a use
> > > > case. Any app should retry with larger buffers until either there's
> > > > a match with score > AVPROBE_SCORE_MAX/4 or there is a reason to not
> > > > provide more data.
> > > There's always a reason not to provide more data -- speed. Reading very
> > > large probes can take quite long for remote files. The MPD author is
> > > reluctant to do this unless there's some hint the file is not garbage.
> > Can you describe the use case in more detail? Because considering
> > "speed" in case probe has failed is kind of like "my program is really
> > fast at not doing anything!".
> Well it's always some kind of tradeoff between how reliable you want
> detection to be and how long you're willing to wait for that. If we can
> provide further hints to make the process easier, IMO we should do that.
That is not a description of a use-case though. The question is if and why
that is a problem in reality and if and why other solutions would not work...
With my suggested patch, that program would probably happily probe 1 GB just
because there's a ID3v2 tag with a broken size for example...
More information about the ffmpeg-devel