[FFmpeg-devel] [RFC] switch to poll()
Tue Nov 16 18:14:31 CET 2010
On Tue, 16 Nov 2010, Martin Storsj? wrote:
> Yes, but that's not what I meant. In patch #1, you do this:
> int j = 1 - (tcp_fd == -1);
> [...] (code not touching j)
> for (j = 1; j < max_p; j++)
> In that case, the complicated initialization of j is just confusing, since
> the initial value isn't used at all. In patch #2, that is of course
> totally correct, but there, you also move the line. That is, if applied
> separately, this shouldn't be in patch #1. If both of them are applied at
> once, this point is moot.
Actually, on second thought, the separate initialization above, int j = 1
- (tcp_fd == -1); is the correct one, you should just remove the j = 1
initialization in the for loop instead.
More information about the ffmpeg-devel