[FFmpeg-devel] [PATCH] Give sane names to the filters dealing with aspect ratio.

[Michael Niedermayer]

On Thu, Nov 18, 2010 at 10:33:02PM +0100, Stefano Sabatini wrote:
> ---
>  libavfilter/Makefile     |    4 ++--
>  libavfilter/allfilters.c |    4 ++--
>  libavfilter/vf_aspect.c  |   24 ++++++++++++------------
>  3 files changed, 16 insertions(+), 16 deletions(-)
> 
> diff --git a/libavfilter/Makefile b/libavfilter/Makefile
> index 71dcf2a..344518c 100644
> --- a/libavfilter/Makefile
> +++ b/libavfilter/Makefile
> @@ -19,7 +19,6 @@ OBJS-$(CONFIG_ANULLSRC_FILTER)               += asrc_anullsrc.o
>  
>  OBJS-$(CONFIG_ANULLSINK_FILTER)              += asink_anullsink.o
>  
> -OBJS-$(CONFIG_ASPECT_FILTER)                 += vf_aspect.o
>  OBJS-$(CONFIG_BLACKFRAME_FILTER)             += vf_blackframe.o
>  OBJS-$(CONFIG_CROP_FILTER)                   += vf_crop.o
>  OBJS-$(CONFIG_CROPDETECT_FILTER)             += vf_cropdetect.o
> @@ -33,8 +32,9 @@ OBJS-$(CONFIG_NULL_FILTER)                   += vf_null.o
>  OBJS-$(CONFIG_OCV_SMOOTH_FILTER)             += vf_libopencv.o
>  OBJS-$(CONFIG_PAD_FILTER)                    += vf_pad.o
>  OBJS-$(CONFIG_PIXDESCTEST_FILTER)            += vf_pixdesctest.o
> -OBJS-$(CONFIG_PIXELASPECT_FILTER)            += vf_aspect.o
>  OBJS-$(CONFIG_SCALE_FILTER)                  += vf_scale.o
> +OBJS-$(CONFIG_SETDAR_FILTER)                 += vf_aspect.o
> +OBJS-$(CONFIG_SETPAR_FILTER)                 += vf_aspect.o

PAR is ambigous, please use SAR (sample aspect ratio), its also what mpeg2 uses

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Awnsering whenever a program halts or runs forever is
On a turing machine, in general impossible (turings halting problem).
On any real computer, always possible as a real computer has a finite number
of states N, and will either halt in less than N cycles or never halt.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101119/2912979e/attachment.pgp>