[FFmpeg-devel] [PATCH 1/4] Implement avfilter_ref_video_buffer().
Sat Nov 20 00:59:55 CET 2010
On date Saturday 2010-11-13 15:02:50 +0100, Stefano Sabatini encoded:
> On date Friday 2010-11-12 20:19:08 +0100, Michael Niedermayer encoded:
> > On Fri, Nov 12, 2010 at 03:49:38PM +0100, Stefano Sabatini wrote:
> > > Other proposals:
> > >
> > > avfilter_get_video_buffer_ref_from_arrays
> > just longer than my suggestion otherwise its the same
> Your suggestion:
> I slightly dislike it as it lacks a verb.
> > > avfilter_ref_video_buffer_arrays
> > ambigous
> "Reference video buffer arrays", that is get a reference for the given
> video buffer arrays (data+linesizes), I don't see that so much
> ambiguous and a name of a function has not to be necessarily
> *completely* explicative.
> > > avfilter_ref_buffer_from_video_buffer_arrays
> > > avfilter_get_video_buffer_ref_from_video_buffer_arrays
> > > avfilter_get_buffer_ref_from_video_buffer_arrays
> > we have no video anything array, as the thing just represents a single frame
> AVFilterVideoBufferRef references just an image anyway, so if this is
> amniguous the same is for the name of that struct.
> Alternatively we could use the term "frame" in place of image (which
> is more consistent with the names already used in the rest of the
> lavfi API, start/end_frame).
> > > avfilter_ref_buffer_from_image_arrays
> > > avfilter_get_video_buffer_ref_from_image_arrays
> > > avfilter_get_buffer_ref_from_image_arrays
> > image arrays implicates to me that there are several images
> That's unfortunately a quirk of the English language, image arrays ~
> images arrays.
> You get the corresponding audio API doing s/video/audio/ and
> Please choose one of the above and let's color this bikeshed.
FFmpeg = Freak & Fabulous Meaningful Patchable Emblematic Generator
More information about the ffmpeg-devel