[FFmpeg-devel] [PATCH] MPEG-4 ALS decoder MCC decoding bug (non-lossless output) (Fixes issue 2387)

[sprezzatura]

Hi,

> > But for now, I attached a patch without those variables removed,
> > and duplicated for all channels.
> 
> Review below:
> 
> ...
> This is not what I wanted to say with my last remark. Storing the constant value
> in ->raw_buffer like you did in the first place is ok!
> 
> > + int *store_prev_samples; ///< contains store_prev_samples flags
> for all channels
> 
> Storing these per channel definitely removes a bug and complies to this patch,
> so it is ok although I've no file in my test suite nor does your uploaded file
> suffer from this buggy field. Ok.
> 
> All other changes ok.
> 
> Getting close!

Sorry, I don't think I follow. Do you want me to store the const value in
->raw_buffer like in the first patch, and store store_prev_samples per channel
like in the second patch?

Regards,

Sprezz