[FFmpeg-devel] [PATCH] RTP depacketizer for QCELP

Ronald S. Bultje rsbultje
Mon Nov 29 16:43:15 CET 2010

Hi Martin,

On Mon, Nov 29, 2010 at 4:24 AM, Martin Storsj? <martin at martin.st> wrote:

2 and 3 are fine, can be applied anytime. 4 duplicates code, I think,
can you somehow extract that? The depacketizer itself looks good on a
first view but I want to look at it a little more.

I always thought that this worked already, as long as the
"x-Purevoice" string was in the SDP. Is the new code required for the
case were we use a static ID without the string (just "12")?

> +                    /* 0 actually is a valid static payload id, but that one
> +                     * (PCMU) doesn't require a custom depacketizer */

That's a little hacky... Should at least be documented in the struct...


More information about the ffmpeg-devel mailing list