[FFmpeg-devel] [PATCH] Port gradfun to libavfilter (GCI)

Nolan L nol888
Tue Nov 30 03:48:18 CET 2010


On Mon, Nov 29, 2010 at 7:18 AM, Nolan L <nol888 at gmail.com> wrote:

> As part of a GCI task, I've ported the gradfun debanding filter from
> mplayer to libavfilter.
>
> The patch includes changes to the build system to account for CPU
> optimizations that weren't present previously.
>
> There is a SSE2 method that remains unported due to lack of SSE2 detection
> in the configure script that I wasn't quite sure how to add.
>

Here is the resulting patch from the first round of feedback. Things that
still need to be addressed (mostly with the asm):
    -Factoring the asm; I don't have enough asm experience to do this.
    -alignment issues with the asm code. (hopefully someone more experienced
can take care of this.)
    -gpl vs lgpl

I looked at direct rendering, and decided that it would be simpler to keep
it as is. If someone could point out a quick way to implement this without
almost rewriting the filter I'd be happy to oblige.

As the code in x86/ needs to be compiled and linked (and can be compiled)
regardless of compiler support for certain instruction sets, I dropped the
additional conditional compilation lines in the Makefile.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gradfunv2.patch
Type: text/x-patch
Size: 18841 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101129/3669858a/attachment.bin>



More information about the ffmpeg-devel mailing list