[FFmpeg-devel] [PATCH 3/4] Document url_get_filename().

Michael Niedermayer michaelni
Fri Oct 1 17:39:44 CEST 2010


On Fri, Oct 01, 2010 at 05:12:43PM +0200, Stefano Sabatini wrote:
> On date Thursday 2010-09-30 11:23:56 +0200, Stefano Sabatini encoded:
> > ---
> >  libavformat/avio.h |    6 ++++++
> >  1 files changed, 6 insertions(+), 0 deletions(-)
> > 
> > diff --git a/libavformat/avio.h b/libavformat/avio.h
> > index 1cc7fa0..34437bc 100644
> > --- a/libavformat/avio.h
> > +++ b/libavformat/avio.h
> > @@ -204,6 +204,12 @@ int url_get_file_handle(URLContext *h);
> >   * @return maximum packet size in bytes
> >   */
> >  int url_get_max_packet_size(URLContext *h);
> > +
> > +/**
> > + * Copy the filename of the resource accessed by h to buf.
> > + *
> > + * @buf_size size in bytes of buf
> > + */
> >  void url_get_filename(URLContext *h, char *buf, int buf_size);
> 
> I'll apply in three days if I see no comments.

i dont mind but i think this is a bit redundant

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101001/68c417c8/attachment.pgp>



More information about the ffmpeg-devel mailing list