[FFmpeg-devel] [PATCH] mov auto crop

Aurelien Jacobs aurel
Sat Oct 2 19:15:25 CEST 2010

On Sat, Oct 02, 2010 at 02:57:43PM +0200, Benjamin Larsson wrote:
> On 10/02/2010 04:51 AM, Baptiste Coudurier wrote:
> > Hi guys,
> > 
> > $subject.
> > 
> > Please keep in mind that this issue has been present for _years_ and
> > nobody dared to fix it. I believe the patch is not so hackish/ugly.
> > 
> > I restrict it to codecs not supporting arbitrary resolutions that can be
> > stored in .mov by quicktime.
> > 
> > Maybe exporting to "crop", "wxh" is better, I don't know.
> > 
> > I plan to add auto-rotate for iphone 3gs files this way as well :)
> > 
> Jolly good. But would it be possible to move this code to the api and
> just not in the ffmpeg commandline tool?

I agree. Before this patch is committed, I would like to see a proper
API patch, whether it is by documenting the metadata API or by adding
some fields to the AVFormatContext struct.
After we have a clean and documented API for this, it will be trivial
and un-controversial to use this API in any muxer/demuxer and tools
including all the API users which are not part of the FFmpeg repository.

I have to say that I don't like much the use of the metadata API for
this. I forces every existing applications to filter out metadata before
copying them to a transcoded file (which might have been resized, so the
cropping values don't make any sens anymore). So in some way, it kind of
break current public API...


More information about the ffmpeg-devel mailing list