[FFmpeg-devel] [PATCH] rtpdec_svq3: Don't look for the unused RTP_FLAG_KEY flag

Martin Storsjö martin
Sun Oct 3 16:00:51 CEST 2010


When looking over some code, I noticed that the svq3 depacketizer looks 
for the RTP_FLAG_KEY flag in the flags variable, and sets AV_PKT_FLAG_KEY 
accordingly. However, nothing ever sets the RTP_FLAG_KEY in flags (there's 
no such bit in a RTP packet, only RTP_FLAG_MARKER is extracted and set), 
RTP_FLAG_KEY is only used internally within some RDT code and somewhere in 
the rtpdec_asf code currently.

Therefore, these lines of code in rtpdec_svq3 are nothing more than 
historical cruft/misunderstandings. Decoding still works just fine if this 
is removed.

Josh, I'm CCing you since I'm not sure if you're still reading this list 
regularly. I checked the wiki docs on this, and it currently says

    "the RTP marker bit indicates whether the payload data is a keyframe"

which doesn't correspond to what the code currently does, and isn't true. 
(Currently the RTP marker bit isn't used at all in the code, and I'm not 
sure exactly what it maps to. In most formats, it indicates end of 
multi-packet frame, but we have another bit within the payload for that.)

So, are you ok with removing this incorrect sentence?

// Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-rtpdec_svq3-Don-t-look-for-the-RTP_FLAG_KEY-flag-not.patch
Type: text/x-diff
Size: 1473 bytes
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101003/ad16e62c/attachment.patch>

More information about the ffmpeg-devel mailing list