[FFmpeg-devel] [PATCH] matroskaenc: write tags.

Reimar Döffinger Reimar.Doeffinger
Mon Oct 4 23:17:50 CEST 2010

On Mon, Oct 04, 2010 at 10:43:14PM +0200, Aurelien Jacobs wrote:
> > +        else if (*p >= 'a' && *p <= 'z')
> > +            *p = toupper(*p);
> I'm not sure about all the implications about using toupper (especially
> depending on the $LANG and friends)... It may be safe as you already
> check the range of the source character

That does not help one bit. E.g. the uppercase of 'i' is not 'I' in
And yes, (almost?) all uses of strcasecmp in ffmpeg are wrong for that reason.

More information about the ffmpeg-devel mailing list