[FFmpeg-devel] [ping] [PATCH] mmx implementation of vc-1 inverse transformations
Tue Oct 5 21:16:06 CEST 2010
On Sat, Oct 02, 2010 at 09:07:58AM -0400, Ronald S. Bultje wrote:
> On Sat, Oct 2, 2010 at 4:19 AM, Kostya <kostya.shishkov at gmail.com> wrote:
> > On Fri, Oct 01, 2010 at 11:45:24PM +0400, Yuriy Kaminskiy wrote:
> >> Yuriy Kaminskiy wrote:
> >> > Yuriy Kaminskiy wrote:
> >> >> Hello!
> >> >>
> >> >> I've noticed old and forgotten patch series by Victor Pollex
> >> >> (http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/2008-July/050503.html),
> >> >> forward-ported it to current ffmpeg, it seems gives 12%-20% faster decoding
> >> >> (benchmarked with ffmpeg [...] -f yuv4mpeg /dev/null, verified with -f framecrc).
> >> [...]
> >> >> be easier to drop that and just use _transposed flags.
> >> >> I've also fixed problematic asm arguments: s/(0x\d\d)%0/$1(%0)/.
> >> > Doh. Some of this kind somehow slipped (I was totally sure I've replaced all
> >> > them long time ago :-|). Fixed version attached.
> >> ... and during forward porting ff_vc1dsp_init_sse2() call somehow landed in
> >> wrong place [3dnow section instead of sse2] (coincidently it happen to work on
> >> my cpu :-|).
> >> Only difference with 40_vc1dsp_sse2-4.patch - move this call to proper place.
> > I'm leaving this to review for somebody who knows x86 SIMD better than
> > me (Michael/Jason/Loren/somebody else).
> > Even better if Ronald would yasmify it but that's a mere wish.
> Not necessarily, but the patch does miss clobber marking which I
> intend to start making a big deal about. No need to keep re-breaking
> (In other words, can this hold a little until we finish the
> xmm-clobber-bikeshed in the relevant thread? :-).)
holding it for 1 week is ok beyond that IMHO its not reasonable
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
The real ebay dictionary, page 2
"100% positive feedback" - "All either got their money back or didnt complain"
"Best seller ever, very honest" - "Seller refunded buyer after failed scam"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel