[FFmpeg-devel] [PATCH 3/3] Export metadata in the generic format.

Aurelien Jacobs aurel
Tue Oct 5 22:05:48 CEST 2010

On Tue, Oct 05, 2010 at 07:57:06PM +0200, Anton Khirnov wrote:
> deprecate old conversion API.
> [...]

I'm not totally sure after all those changes, so maybe you could refresh
my mind, but to me, it looks like the only problem this patch is fixing
is supporting demuxer which could make use of different conversion
tables depending on the actual metadata format present in the file
(ie. supporting id3v1 append at the end of any kind of format).

Maybe we could solve this problem in a simpler way by just moving
AV(In/Out)putFormat.metadata_conv to AVMetadata.conv.
When reading metadata out of a file, the demuxer would set
AVMetadata.conv to the appropriate conversion table.
Then we just have to change to av_metadata_conv() calls to read this new
pointer instead of the old one.

AFAICT, the change would be simpler and it would acheive the same result
while still exporting the container specific metadata keys to the
application, but I may have missed something obvious...


More information about the ffmpeg-devel mailing list