[FFmpeg-devel] [PATCH] odd-height RGB->yuv420 fix invalid reads

Reimar Döffinger Reimar.Doeffinger
Fri Oct 8 07:49:35 CEST 2010

On Fri, Oct 08, 2010 at 04:03:36AM +0200, Michael Niedermayer wrote:
> On Thu, Oct 07, 2010 at 09:35:37PM +0200, Reimar D?ffinger wrote:
> > Hello,
> > while it will leave the last line(s) uninitialized (do they even exist/will
> > they have been allocated?), below patch fixes the out-of-bounds reads.
> > Should fix the crash part of issue 2279.
> they must have been allocated or there is a bug in the allocation
> and they should be filled

I'm not sure I understand really, but I think attached patch will
fill them (somewhat) correctly.
Note that the same issue (the uninitialized, not the crash part)
still exists for odd width AFAICT.
However for the given sample it at least solves all valgrind issues.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sws_oddh.diff
Type: text/x-diff
Size: 925 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101008/a6614bef/attachment.diff>

More information about the ffmpeg-devel mailing list