[FFmpeg-devel] [PATCH] Implement cropdetect filter.
Sat Oct 9 20:05:12 CEST 2010
On Sat, Oct 09, 2010 at 07:23:59PM +0200, Stefano Sabatini wrote:
> On date Saturday 2010-10-09 19:11:29 +0200, Michael Niedermayer encoded:
> > On Sat, Oct 09, 2010 at 06:51:23PM +0200, Stefano Sabatini wrote:
> > Code ported from other projects must not be cosmtically reformated because
> > it makes merging changes between trees impossible, that is unless both sides
> > are identically reformated or one is removed and replaced by using the other
> > (tabs are the exception because we cant commit them)
> I don't think that's much of an issue as the code is not mechanically
> moved, so a patch against one file cannot be mechanically applied to
> the other file, and manual intervention is required anyway.
the correct way is to mechanically copy all files and spend 5 days writing
a wraper to load libmpcodecs filters.
you spend 2 days for each of the 76 filters, which is half a year work
i dont mind honestly if you port all and format them pretty in K&R but i
think this is the much harder way.
So if you like we can continue with this patch here and i can take another
look at it or we can forget that and work on a wraper?
(filters like crop/scale are different of course they are fundamental enough
so we want them truly ported and not used over a wraper)
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
The real ebay dictionary, page 1
"Used only once" - "Some unspecified defect prevented a second use"
"In good condition" - "Can be repaird by experienced expert"
"As is" - "You wouldnt want it even if you were payed for it, if you knew ..."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel