[FFmpeg-devel] [PATCH] Add a new flag AVFMT_NETWORK
Mon Oct 11 16:37:56 CEST 2010
On Mon, Oct 11, 2010 at 05:19:09PM +0300, Martin Storsj? wrote:
> On Mon, 11 Oct 2010, Michael Niedermayer wrote:
> > On Mon, Oct 11, 2010 at 04:26:59PM +0300, Martin Storsj? wrote:
> > > Hi,
> > >
> > > By adding a flag AVFMT_NETWORK, we could move calling
> > > ff_network_init()/ff_network_close to common code in utils.c, instead of
> > > having to have this in the muxers/demuxers that use network functions
> > > before opening protocols.
> > >
> > > This allows us to remove the extra ff_network_init/ff_network_close calls
> > > from the rtsp/sdp/sap demuxers/muxers open/close functions, as in the
> > > second patch.
> > >
> > > Opinions?
> > 30 lines added, 19 removed
> > so it seems its more complex after this patch, what do we gain with it?
> Yes, slightly. But if more muxers/demuxers that use network functions
> directly are added, they would all need the same initialization code (call
> ff_network_init() at the start, if returning an error, call
> ff_network_close(), oterwise call ff_network_close() in the close
> If you don't think this is worth the extra flag, I'm ok with keeping this
> code within the (de)muxers also.
ive no objection to the change, i just wanted to point out that i dont really
see what we gain from it at the moment
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Frequently ignored awnser#1 FFmpeg bugs should be sent to our bugtracker. User
questions about the command line tools should be sent to the ffmpeg-user ML.
And questions about how to use libav* should be sent to the libav-user ML.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel