[FFmpeg-devel] [PATCH 4/4] Use an AVMetadata struct for storing metadata, simplify.

Stefano Sabatini stefano.sabatini-lala
Sat Oct 16 17:23:29 CEST 2010


On date Friday 2010-04-30 23:29:56 +0200, Aurelien Jacobs encoded:
> On Sat, Apr 24, 2010 at 03:34:17PM +0200, Stefano Sabatini wrote:
> > ---
> >  ffmpeg.c |   17 ++++++-----------
> >  1 files changed, 6 insertions(+), 11 deletions(-)
> 
> Overal, this patch looks OK, except one detail :
> 
> > [...]
> > @@ -3532,10 +3528,9 @@ static void opt_output_file(const char *filename)
> >  
> >          oc->timestamp = rec_timestamp;
> >  
> > -        for(; metadata_count>0; metadata_count--){
> > -            av_metadata_set2(&oc->metadata, metadata[metadata_count-1].key,
> > -                                            metadata[metadata_count-1].value, 0);
> > -        }
> > +        while ((tag = av_metadata_get(oc->metadata, "", tag, AV_METADATA_IGNORE_SUFFIX)))
> > +            av_metadata_set2(&oc->metadata, tag->key, tag->value, 0);
> 
> Here you copy oc->metadata to oc->metadata... This must be wrong.
> I guess you want to use 'metadata' instead of 'oc->metadata' in the
> av_metadata_get() call.

Fixed and applied.
-- 
FFmpeg = Frenzy & Fierce Mastodontic Puristic Elitarian Gigant



More information about the ffmpeg-devel mailing list