[FFmpeg-devel] [PATCH] Possible fix for H264 with missing crop rectangle

Michael Niedermayer michaelni
Sun Oct 31 11:49:00 CET 2010

On Tue, Oct 26, 2010 at 02:41:52PM +0100, Nigel Touati-Evans wrote:
> have some 1080p h264 video inside a mov wrapper which ffmpeg decodes
> as 1088 (with a black line along the bottom). Quicktime correctly
> decodes as 1080. It seems that the camera does not write a cropping
> rectangle to the h264 stream and relies on the Quicktime header.
> I have made a patch (attached) to set the cropping rectangle based on
> the header height if sensible, which fixes my video. However I'm not
> sure this is the correct way to go about it (and I had to change
> liibavcodec/utils.c to make an image size test weaker, though the new
> condition is consistent with the conditions in the previous lines, so
> maybe it is ok).

this is a hack, isnt going to work and thus not ok
there was some discussion on how to fix this properly, i dont have a link to
it ATM though

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101031/39908393/attachment.pgp>

More information about the ffmpeg-devel mailing list