[FFmpeg-devel] [PATCH] nasm support
Fri Sep 3 20:40:41 CEST 2010
Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
> On Fri, Sep 03, 2010 at 06:21:11PM +0100, M?ns Rullg?rd wrote:
>> > @@ -2569,8 +2570,21 @@
>> > elf) enabled debug && append YASMFLAGS "-g dwarf2" ;;
>> > esac
>> > if ! disabled yasm; then
>> > - check_yasm "pabsw xmm0, xmm0" && enable yasm ||
>> > - warn "yasm not found, performance will suffer"
>> > + check_yasm "pabsw xmm0, xmm0" && enable yasm
>> > + if ! enabled yasm ; then
>> > + yasmexe="nasm"
>> > + if enabled x86_64 ; then
>> > + case "$objformat" in
>> > + elf) objformat=elf64 ;;
>> > + win32) objformat=win64 ;;
>> > + esac
>> > + fi
>> > + YASMFLAGS="-f $objformat -DARCH_$(toupper $subarch)"
>> > + enabled pic && append YASMFLAGS "-DPIC"
>> > + test -n "$extern_prefix" && append YASMFLAGS "-DPREFIX"
>> > + check_yasm "pabsw xmm0, xmm0" && enable yasm ||
>> > + warn "yasm/nasm not found, performance will suffer"
>> > + fi
>> > fi
>> This diff is not against current svn
> Updated version was sent shortly after.
I noticed after sending the reply.
>> and such duplication is not acceptable.
> I know, I was hoping for you or someone else to come up with
> a nice way.
> I only manage to come up with something like attached.
I'll concoct something nicer if the asm experts say it makes sense.
> Btw. am I missing something or are we quite pointlessly
> constructing YASMFLAGS even when yasm is disabled?
Maybe, but I don't consider it an urgent issue. I'll fix it if we're
anyway poking at it for this of course.
mans at mansr.com
More information about the ffmpeg-devel