[FFmpeg-devel] [PATCH] Clean up av_get_cpu_flag()
Wed Sep 8 22:58:57 CEST 2010
"Ronald S. Bultje" <rsbultje at gmail.com> writes:
> 2010/9/8 M?ns Rullg?rd <mans at mansr.com>:
>> "Ronald S. Bultje" <rsbultje at gmail.com> writes:
>>> On Wed, Sep 8, 2010 at 3:46 PM, Mans Rullgard <mans at mansr.com> wrote:
>>>> +/* The following CPU-specific functions shall not be called directly. */
>>>> +int av_get_cpu_flags_arm(void);
>>>> +int av_get_cpu_flags_ppc(void);
>>>> +int av_get_cpu_flags_x86(void);
>>> So remove the av_ prefix? Looks nice otherwise.
>> ff_ prefix instead?
> Probably yes, and then put them in a private header also if wanted (or
I though a separate header for those functions seemed overkill.
> since they're only used in a single place, no header needed).
All non-static functions must have a prototype in a header. We even
enforce that if the compiler supports it.
mans at mansr.com
More information about the ffmpeg-devel